Fix password prompt conditions - #271
Merged
Merged
Conversation
Signed-off-by: Ravjot Brar <ravjot.brar@improving.com>
Signed-off-by: Ravjot Brar <ravjot.brar@improving.com>
Signed-off-by: Ravjot Brar <ravjot.brar@improving.com>
Signed-off-by: Ravjot Brar <ravjot.brar@improving.com>
Signed-off-by: Ravjot Brar <ravjot.brar@improving.com>
| if (!lastOpenedNode) return | ||
| if (lastOpenedNode.connection.connectionDetails.password === undefined && onPasswordRequired) { | ||
| const { password, authType } = lastOpenedNode.connection.connectionDetails | ||
| if (authType !== "iam" && password === undefined && onPasswordRequired) { |
Collaborator
There was a problem hiding this comment.
password === undefined — I'm really worried about all these conditions when we have "" and the ghost of null lurking. I'd really suggest we create a util function
const isBlank = R.either(R.isNil, R.isEmpty)
and do isBlank(password)
Signed-off-by: Ravjot Brar <ravjot.brar@improving.com>
Signed-off-by: Ravjot Brar <ravjot.brar@improving.com>
Signed-off-by: Ravjot Brar <ravjot.brar@improving.com>
Signed-off-by: Ravjot Brar <ravjot.brar@improving.com>
Signed-off-by: Ravjot Brar <ravjot.brar@improving.com>
Signed-off-by: Ravjot Brar <ravjot.brar@improving.com>
Signed-off-by: Ravjot Brar <ravjot.brar@improving.com>
Signed-off-by: Ravjot Brar <ravjot.brar@improving.com>
arseny-kostenko
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prior to this change, if a user (on Electron) connects to their instance that did not require a password initially, they would be prompted for one upon reconnect. Now the empty password is saved in local storage.
Additionally, when a user connected with IAM, they would be prompted with a password since there was no guard.
Change Visualization
Include a screenshot/video of before and after the change.